From 734989f1a484e305de0f24d6cd840bc73800700f Mon Sep 17 00:00:00 2001 From: Simon Gardling Date: Tue, 29 Mar 2022 11:19:01 -0400 Subject: [PATCH] clippy --- src/misc.rs | 2 +- src/suggestions.rs | 13 +++++-------- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/misc.rs b/src/misc.rs index 319a1e5..e5c9d73 100644 --- a/src/misc.rs +++ b/src/misc.rs @@ -335,7 +335,7 @@ pub fn common_substring<'a>(a: &'a str, b: &'a str) -> Option { Some(last_value) } -pub fn chars_take(chars: &Vec, i: usize) -> String { +pub fn chars_take(chars: &[char], i: usize) -> String { if i > chars.len() { panic!("chars_take: i is larget than chars.len()"); } diff --git a/src/suggestions.rs b/src/suggestions.rs index f98e668..d936551 100644 --- a/src/suggestions.rs +++ b/src/suggestions.rs @@ -26,7 +26,7 @@ pub fn generate_hint(input: &str) -> String { let result_five = get_completion(chars_take(&chars, 5)); if let Some(output) = result_five { - return output.to_owned(); + return output; } } @@ -34,7 +34,7 @@ pub fn generate_hint(input: &str) -> String { let result_four = get_completion(chars_take(&chars, 4)); if let Some(output) = result_four { - return output.to_owned(); + return output; } } @@ -42,14 +42,14 @@ pub fn generate_hint(input: &str) -> String { let result_three = get_completion(chars_take(&chars, 3)); if let Some(output) = result_three { - return output.to_owned(); + return output; } } if len >= 2 { let result_two = get_completion(chars_take(&chars, 2)); if let Some(output) = result_two { - return output.to_owned(); + return output; } } @@ -214,10 +214,7 @@ mod tests { for (key, value) in manual_values { values.insert( key.to_string(), - match value { - Some(x) => Some(x.to_string()), - None => None, - }, + value.map(|x| x.to_string()), ); }